test: backport unordered tx systemtest #23711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
systemtests/rest_support.go
Outdated
Comment on lines
109
to
111
| for key, value := range headers { | ||
| req.Header.Set(key, value) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
systemtests/system.go
Outdated
Comment on lines
426
to
432
| go func() { | ||
| for start, current := s.currentHeight.Load(), s.currentHeight.Load(); current == start; current = s.currentHeight.Load() { | ||
| time.Sleep(s.blockTime) | ||
| } | ||
| done <- s.currentHeight.Load() | ||
| close(done) | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
systemtests/system.go
Outdated
Comment on lines
616
to
622
| go func() { | ||
| _ = cmd.Wait() // blocks until shutdown | ||
| s.Logf("Node stopped: %d\n", pid) | ||
| s.pidsLock.Lock() | ||
| delete(s.pids, pid) | ||
| s.pidsLock.Unlock() | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
…nto technicallyty/STA-102/backport-unordered-tx-systemtest
technicallyty
changed the base branch from
technicallyty/backport-6ec53aaf54-unorderedtx-part-1
to
technicallyty/STA-118/timeout_height_time_based
…echnicallyty/STA-102/backport-unordered-tx-systemtest
…echnicallyty/STA-102/backport-unordered-tx-systemtest
aljo242
approved these changes
Feb 24, 2025
…echnicallyty/STA-102/backport-unordered-tx-systemtest
…echnicallyty/STA-102/backport-unordered-tx-systemtest
technicallyty
merged commit 27f5ace
into
technicallyty/STA-118/timeout_height_time_based
54 checks passed
technicallyty
deleted the
technicallyty/STA-102/backport-unordered-tx-systemtest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backports the undordered tx system test
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...